Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sorting of imports #5937

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Sorting of imports #5937

merged 2 commits into from
Oct 13, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Oct 13, 2023

I'm using the black style for sorting imports. There are likely a lot of opinions on the best way to do it.

@codecov-commenter
Copy link

codecov-commenter commented Oct 13, 2023

Codecov Report

Merging #5937 (be29819) into main (53f816e) will decrease coverage by 0.01%.
The diff coverage is 97.86%.

@@            Coverage Diff             @@
##             main    #5937      +/-   ##
==========================================
- Coverage   88.58%   88.58%   -0.01%     
==========================================
  Files         313      313              
  Lines       65100    65066      -34     
==========================================
- Hits        57668    57636      -32     
+ Misses       7432     7430       -2     
Flag Coverage Δ
ui-tests 23.25% <93.16%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
holoviews/annotators.py 86.26% <100.00%> (ø)
holoviews/core/__init__.py 100.00% <100.00%> (ø)
holoviews/core/accessors.py 83.91% <100.00%> (ø)
holoviews/core/boundingregion.py 62.42% <100.00%> (ø)
holoviews/core/data/__init__.py 86.53% <100.00%> (ø)
holoviews/core/data/array.py 83.41% <100.00%> (ø)
holoviews/core/data/cudf.py 19.10% <ø> (ø)
holoviews/core/data/dictionary.py 90.90% <100.00%> (ø)
holoviews/core/data/grid.py 86.27% <100.00%> (ø)
holoviews/core/data/ibis.py 82.01% <100.00%> (ø)
... and 251 more

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@hoxbro hoxbro merged commit 912d520 into main Oct 13, 2023
11 checks passed
@hoxbro hoxbro deleted the importsort branch October 13, 2023 17:18
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants