Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Holoviews maintenance #5987

Merged
merged 12 commits into from
Nov 17, 2023
Merged

Holoviews maintenance #5987

merged 12 commits into from
Nov 17, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Nov 17, 2023

Following some of the advice of Scientific Python guide and automated review tool.

Also setting filter warnings to error by default 🎉

@codecov-commenter
Copy link

codecov-commenter commented Nov 17, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (a3b419a) 88.58% compared to head (65d458f) 88.58%.
Report is 2 commits behind head on main.

Files Patch % Lines
holoviews/tests/plotting/bokeh/test_server.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5987      +/-   ##
==========================================
- Coverage   88.58%   88.58%   -0.01%     
==========================================
  Files         315      315              
  Lines       65554    65573      +19     
==========================================
+ Hits        58074    58086      +12     
- Misses       7480     7487       +7     
Flag Coverage Δ
ui-tests 23.15% <14.28%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro enabled auto-merge (squash) November 17, 2023 12:53
@hoxbro hoxbro merged commit 6d3a282 into main Nov 17, 2023
10 checks passed
@hoxbro hoxbro deleted the holoviews_maint branch November 17, 2023 13:42
@hoxbro hoxbro added the type: maintenance infrastructure and maintenance of CI label Nov 23, 2023
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: maintenance infrastructure and maintenance of CI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants