Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add extra check to detect if we are in jupyterlite #6007

Merged
merged 2 commits into from
Dec 5, 2023

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Dec 5, 2023

_JUPYTERLAB is no longer there when running jupyterlite, so found another way to detect it.

https://jupyter.org/try-jupyter/lab/

@hoxbro hoxbro added the type: compatibility Compability with upstream packages label Dec 5, 2023
@codecov-commenter
Copy link

codecov-commenter commented Dec 5, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (7a4fc21) 88.61% compared to head (bd8ea5a) 88.61%.

Files Patch % Lines
holoviews/pyodide.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6007   +/-   ##
=======================================
  Coverage   88.61%   88.61%           
=======================================
  Files         315      315           
  Lines       65593    65593           
=======================================
  Hits        58122    58122           
  Misses       7471     7471           
Flag Coverage Δ
ui-tests 23.27% <0.00%> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro enabled auto-merge (squash) December 5, 2023 09:38
@philippjfr
Copy link
Member

Also adding pyodide_http.patch_all() like what is done in Panel.

Doesn't that automatically get inherited from Panel?

holoviews/pyodide.py Outdated Show resolved Hide resolved
@hoxbro hoxbro merged commit 50e51cd into main Dec 5, 2023
11 checks passed
@hoxbro hoxbro deleted the extra_check_jupyterlite branch December 5, 2023 12:43
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: compatibility Compability with upstream packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants