Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose setting hard navigable bounds #6056
Expose setting hard navigable bounds #6056
Changes from 23 commits
63bbabc
2acd4f8
30af8a0
ccef3ca
c3da8f6
77d2f31
d6b8783
8d167e5
54ff9ae
5eff4d8
6d25282
b2d9110
48d15a5
3133fe6
ea187a8
45cc495
4056f6e
05b9b0f
38b396b
fad2bee
bae1705
4432966
828ec3d
ca106d1
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are there other inherited classes that need
lims_as_soft_ranges
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
hmm are you hinting at the
get_extents
method of theclass GenericOverlayPlot
?It doesn't appear to be necessary because even for overlay plots, GenericElementPlot's version of
get_extents
withlims_as_soft_ranges
set to True seems to be called anyway. But honestly it's all pretty confusing and get_extents gets called numerous times so I could be missing something.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not hinting at anything specific; just that other classes could also need to implement
lims_as_soft_ranges
if they don't have thesuper
. But I think we should wait and see if there is a demand for it, before doing anything.