Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow Bars to be plotted on continuous axes #6145
Allow Bars to be plotted on continuous axes #6145
Changes from 18 commits
971bcee
8b180a9
a197c09
96ce1c8
d20dbbc
783e56c
7023a5c
ff1348b
89660e8
baefbbd
62ce288
63b9d92
123edc8
455e600
d3228b5
030865d
36334d0
f816c13
b0eab97
5ce29b0
be03d0c
bc5881d
685bee9
2b7c88a
9b8f0b7
d1a9ca7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These kind of magic numbers seems hacky. Are you sure there is not a better way?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAIK no (notice all the NA's)
Without:
With the "hack"
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is what is happening behind the scenes (haven't added a small eps).
I would have thought I could use
t.set_text(label)
in the for-loop. But it does not seem to work with Matplotlib, see here:So the small diff is OK. Maybe make it relative to the width:
goffset += width / 1000