-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ensure plot ranges for all renderers are combined in auto-ranging #6173
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6173 +/- ##
=======================================
Coverage 88.68% 88.68%
=======================================
Files 316 316
Lines 66072 66072
=======================================
Hits 58598 58598
Misses 7474 7474
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated the code to work with overlay. Can you please review those changes?
Other than that, it looks good to me; you can merge after looking at my changes.
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Fixes a small oversight in the auto-ranging implementation by combining the ranges for all renderers instead of overwriting them. Also simplifies the code by using the new
Bokeh.index.find_one
API instead of rolling our own implementation.Fixes #6033