Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't error on TypeError in DaskInterface when sorting #6221

Merged
merged 1 commit into from
May 17, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented May 7, 2024

Observed this behavior when using dask-geopandas.

@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label May 7, 2024
Copy link

codecov bot commented May 7, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 88.21%. Comparing base (bc684e3) to head (68de75d).

Files Patch % Lines
holoviews/core/data/dask.py 60.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6221      +/-   ##
==========================================
- Coverage   88.21%   88.21%   -0.01%     
==========================================
  Files         321      321              
  Lines       67289    67292       +3     
==========================================
+ Hits        59361    59362       +1     
- Misses       7928     7930       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit 023ad71 into main May 17, 2024
13 of 14 checks passed
@hoxbro hoxbro deleted the dont-error-typeerror branch May 17, 2024 11:17
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants