Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for cticks #6257

Merged
merged 7 commits into from
Jun 4, 2024
Merged

Add support for cticks #6257

merged 7 commits into from
Jun 4, 2024

Conversation

ahuang11
Copy link
Collaborator

@ahuang11 ahuang11 commented Jun 4, 2024

Closes #5723

import numpy as np
import holoviews as hv

hv.extension("bokeh")

img = hv.Image(np.array([[0, 1], [2, 3]])).opts(
    cticks=[(1, "A"), (2, "B")], colorbar=True
)
img
image

Didn't implement for matplotlib because it already has cbar_ticks

@ahuang11 ahuang11 requested a review from hoxbro June 4, 2024 18:34
@ahuang11 ahuang11 added the type: enhancement Minor feature or improvement to an existing feature label Jun 4, 2024
@ahuang11 ahuang11 added this to the 1.19.0 milestone Jun 4, 2024
Copy link

codecov bot commented Jun 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.48%. Comparing base (2ba3d78) to head (d72f80c).
Report is 9 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6257      +/-   ##
==========================================
+ Coverage   88.39%   88.48%   +0.09%     
==========================================
  Files         323      323              
  Lines       67620    67687      +67     
==========================================
+ Hits        59770    59896     +126     
+ Misses       7850     7791      -59     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

holoviews/plotting/bokeh/util.py Outdated Show resolved Hide resolved
holoviews/plotting/bokeh/element.py Outdated Show resolved Hide resolved
holoviews/plotting/bokeh/element.py Outdated Show resolved Hide resolved
holoviews/plotting/bokeh/util.py Show resolved Hide resolved
@ahuang11 ahuang11 requested a review from hoxbro June 4, 2024 19:44
@hoxbro hoxbro enabled auto-merge (squash) June 4, 2024 19:50
@hoxbro hoxbro merged commit d74dc71 into main Jun 4, 2024
14 checks passed
@hoxbro hoxbro deleted the cticks branch June 4, 2024 20:18
Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add cticks (colorbar ticks) to opts
2 participants