Hold rendering until a plot has been fully updated #6265
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philippjfr
added
the
type: enhancement
philippjfr
commented
Jun 6, 2024
philippjfr
commented
Jun 6, 2024
philippjfr
commented
Jun 6, 2024
hoxbro
reviewed
Jun 6, 2024
hoxbro
reviewed
Jun 6, 2024
hoxbro
reviewed
Jun 6, 2024
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6265 +/- ##
=======================================
Coverage 88.53% 88.53%
=======================================
Files 323 323
Lines 67806 67816 +10
=======================================
+ Hits 60030 60040 +10
Misses 7776 7776 ☔ View full report in Codecov by Sentry. |
hoxbro
approved these changes
Jun 6, 2024
|
This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #6247 by always holding rendering until a plot has been fully updated.