Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix bar with one value in it #6301

Merged
merged 2 commits into from
Jul 4, 2024
Merged

Fix bar with one value in it #6301

merged 2 commits into from
Jul 4, 2024

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Jun 28, 2024

Fixes #6300

A MRE:

import holoviews as hv
import pandas as pd

hv.extension("bokeh")

df = pd.DataFrame({"time": [1], "value": [-1]})
hv.Bars(df)

Need to add the MRE as a test.

@hoxbro hoxbro added this to the 1.19.1 milestone Jun 28, 2024
@hoxbro hoxbro added the type: bug Something isn't correct or isn't working label Jun 28, 2024
@hoxbro hoxbro changed the title Update to work with one value bar Fix bar with one value in it Jun 28, 2024
@hoxbro hoxbro marked this pull request as ready for review July 1, 2024 08:13
Copy link

codecov bot commented Jul 1, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.52%. Comparing base (febe075) to head (24f8da4).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6301   +/-   ##
=======================================
  Coverage   88.52%   88.52%           
=======================================
  Files         323      323           
  Lines       67996    68007   +11     
=======================================
+ Hits        60193    60204   +11     
  Misses       7803     7803           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro merged commit 2bcd663 into main Jul 4, 2024
13 checks passed
@hoxbro hoxbro deleted the fix_one_bar branch July 4, 2024 09:45
@MarcSkovMadsen
Copy link
Collaborator

Thx

Copy link

This pull request has been automatically locked since there has not been any recent activity after it was closed. Please open a new issue for related bugs.

@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Continous Bars no longer working
2 participants