Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MultiAxisTap stream #6374

Merged
merged 15 commits into from
Sep 18, 2024
Merged

Add MultiAxisTap stream #6374

merged 15 commits into from
Sep 18, 2024

Conversation

philippjfr
Copy link
Member

Retrofitting the existing Tap stream with support for multiple axis was too awkward. This PR instead implements a MultiAxisTap stream which provides xs and ys parameters giving you the tap locations indexed by the name of the dimension.

@philippjfr philippjfr added the type: enhancement Minor feature or improvement to an existing feature label Sep 17, 2024
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 81.57895% with 14 lines in your changes missing coverage. Please review.

Project coverage is 88.49%. Comparing base (099d3de) to head (21a12e0).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/plotting/bokeh/callbacks.py 76.47% 8 Missing ⚠️
holoviews/tests/ui/bokeh/test_callback.py 80.00% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6374      +/-   ##
==========================================
- Coverage   88.50%   88.49%   -0.01%     
==========================================
  Files         323      323              
  Lines       68194    68265      +71     
==========================================
+ Hits        60355    60412      +57     
- Misses       7839     7853      +14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@hoxbro hoxbro linked an issue Sep 18, 2024 that may be closed by this pull request
@hoxbro hoxbro merged commit 9d7fadb into main Sep 18, 2024
12 checks passed
@hoxbro hoxbro deleted the multi_tap branch September 18, 2024 13:50
hoxbro pushed a commit that referenced this pull request Sep 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Tap stream for multi_y
2 participants