Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle datetimes and empty selections better for inspect operations #6377

Merged
merged 6 commits into from
Sep 26, 2024

Conversation

philippjfr
Copy link
Member

A number of fixes for inspect operations:

  • Initialize with empty x/y coordinate
  • Handle undefined x/y coordinates
  • Allow datetime axis
  • Allow axes with different dimensions, e.g. datetime and numeric (by normalizing space before computing distances)

@philippjfr philippjfr added the type: enhancement Minor feature or improvement to an existing feature label Sep 18, 2024
Copy link

codecov bot commented Sep 18, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 7 lines in your changes missing coverage. Please review.

Project coverage is 88.50%. Comparing base (88996ed) to head (c1fac79).
Report is 6 commits behind head on main.

Files with missing lines Patch % Lines
holoviews/operation/datashader.py 75.00% 6 Missing ⚠️
holoviews/tests/operation/test_datashader.py 94.44% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff            @@
##             main    #6377    +/-   ##
========================================
  Coverage   88.50%   88.50%            
========================================
  Files         323      323            
  Lines       68281    68387   +106     
========================================
+ Hits        60429    60524    +95     
- Misses       7852     7863    +11     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jbednar jbednar changed the title Handle datetimes and empty selections better inspect operations Handle datetimes and empty selections better for inspect operations Sep 18, 2024
Copy link
Member

@jbednar jbednar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Those changes look good to me, though I'm not an expert in datetime dtypes.

Copy link
Member

@hoxbro hoxbro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some nit comments.

holoviews/operation/datashader.py Show resolved Hide resolved
holoviews/operation/datashader.py Outdated Show resolved Hide resolved
holoviews/operation/datashader.py Show resolved Hide resolved
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@philippjfr philippjfr enabled auto-merge (squash) September 26, 2024 10:04
@philippjfr philippjfr merged commit 008af09 into main Sep 26, 2024
13 checks passed
@philippjfr philippjfr deleted the inspection_improvements branch September 26, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: enhancement Minor feature or improvement to an existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants