-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle datetimes and empty selections better for inspect operations #6377
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #6377 +/- ##
========================================
Coverage 88.50% 88.50%
========================================
Files 323 323
Lines 68281 68387 +106
========================================
+ Hits 60429 60524 +95
- Misses 7852 7863 +11 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Those changes look good to me, though I'm not an expert in datetime dtypes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some nit comments.
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
A number of fixes for
inspect
operations: