-
-
Notifications
You must be signed in to change notification settings - Fork 403
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: Update docstrings to numpydoc style #6506
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6506 +/- ##
=======================================
Coverage 88.76% 88.76%
=======================================
Files 323 323
Lines 68734 68734
=======================================
Hits 61013 61013
Misses 7721 7721 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I skimmed through the code. Looks like tab is wrongly used in some places.
I think this can be fixed with ruff rules: my suggestion would be something like these rules to start with: ruff check holoviews/ --select=D --ignore=D1,D205,D400,D401,D404
And setting the convention to numpy:
[tool.ruff.lint.pydocstyle]
convention = "numpy"
I have no idea why the unit tests on 313 are failing now :( |
Not related to this PR. Will take a look at it now. |
fixes #6502