Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix conda tests #1337

Merged
merged 3 commits into from
May 6, 2024
Merged

Fix conda tests #1337

merged 3 commits into from
May 6, 2024

Conversation

maximlt
Copy link
Member

@maximlt maximlt commented May 6, 2024

fugue 0.9.0 no longer ships with the SQL deps required to run our tests. It's easy to pip install with pip install fugue[sql] but there's no equivalent conda way to do so, so for now the sql deps are listed explicitly.

Copy link

codecov bot commented May 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.39%. Comparing base (c2873cf) to head (8927f3b).

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1337   +/-   ##
=======================================
  Coverage   87.39%   87.39%           
=======================================
  Files          50       50           
  Lines        7489     7490    +1     
=======================================
+ Hits         6545     6546    +1     
  Misses        944      944           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maximlt maximlt merged commit 6c96c7e into main May 6, 2024
27 checks passed
@maximlt maximlt deleted the fix_tests_conda branch May 6, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant