Avoid unncessary rescroll on Column

holoviz · Apr 4, 2024 · 0bed497 · 0bed497
1 parent ba01468
commit 0bed497
Showing 1 changed file with 8 additions and 6 deletions.
diff --git a/panel/models/column.ts b/panel/models/column.ts
@@ -36,8 +36,11 @@ export class ColumnView extends BkColumnView {
 
  trigger_auto_scroll(): void {
  const limit = this.model.auto_scroll_limit
+ if (limit == 0) {
+ return
+ }
  const within_limit = this.distance_from_latest <= limit
- if (limit == 0 || !within_limit) {
+ if (!within_limit) {
  return
  }
 
@@ -50,12 +53,11 @@ export class ColumnView extends BkColumnView {
 
  toggle_scroll_button(): void {
  const threshold = this.model.scroll_button_threshold
- const exceeds_threshold = this.distance_from_latest >= threshold
- if (this.scroll_down_button_el) {
- this.scroll_down_button_el.classList.toggle(
- "visible", threshold !== 0 && exceeds_threshold,
- )
+ if (!this.scroll_down_button_el || threshold === 0) {
+ return
  }
+ const exceeds_threshold = this.distance_from_latest >= threshold
+ this.scroll_down_button_el.classList.toggle("visible", exceeds_threshold)
  }
 
  override render(): void {