Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Logo is shown above instead of on the side with FastListTemplate #2184

Closed
Stubatiger opened this issue Apr 16, 2021 · 3 comments · Fixed by #2469
Closed

Logo is shown above instead of on the side with FastListTemplate #2184

Stubatiger opened this issue Apr 16, 2021 · 3 comments · Fixed by #2469
Labels
type: bug Something isn't correct or isn't working
Milestone

Comments

@Stubatiger
Copy link
Contributor

Hello,

the FastListTemplate shows the provided Logo above the title like this:

import panel as pn

template = pn.template.FastListTemplate(
    title="Fast Panel App",
    logo="https://panel.holoviz.org/_static/logo_stacked.png"
)

template.servable()

grafik

Instead it should be shown beside the title, like in the other templates, for example the bootstrap template:

import panel as pn

template = pn.template.BootstrapTemplate(
    title="Fast Panel App",
    logo="https://panel.holoviz.org/_static/logo_stacked.png"
)

template.servable()

grafik

This is probably because of an extra div tag in the template here:
https://github.com/holoviz/panel/blob/c84ee569927974d6f4a20e927d2f3047ba033277/panel/template/fast/list/fast_list_template.html#L102

grafik

If the Div is removed, the log shows correctly on the side again:

grafik

@philippjfr philippjfr added the type: bug Something isn't correct or isn't working label Apr 16, 2021
@philippjfr philippjfr added this to the v0.11.4 milestone Apr 16, 2021
@philippjfr philippjfr modified the milestones: v0.11.4, v0.12.0 Jun 25, 2021
@Stubatiger
Copy link
Contributor Author

Stubatiger commented Jul 21, 2021

Hello, this issue re-appears in 0.12.0 as the changes you did (mostly just removing the div) are not reflected in the current status as the div is reintroduced in #2484

To fix this, probably its enough to recommit the changes in your PR #2469

@philippjfr philippjfr reopened this Jul 21, 2021
@philippjfr
Copy link
Member

@MarcSkovMadsen Could you address this?

@MarcSkovMadsen
Copy link
Collaborator

Done

MarcSkovMadsen pushed a commit that referenced this issue Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't correct or isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants