Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Distinguish between session creation and execution in session info #1909

Merged
merged 6 commits into from
Jan 17, 2021

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 15, 2021

Panel has supported recording information about user sessions for a while. In doing so it recorded three events, 'started', 'rendered' and 'ended'. However the 'started' event was really recording the time after the session had already been created and fully initialized. This adds a fourth key called 'launched', which records when the initial request arrives but before the dashboard script has been executed.

This means that we can separately compute execution time (server-side) and time to render since initial request (client-side).

@codecov
Copy link

codecov bot commented Jan 17, 2021

Codecov Report

Merging #1909 (b551b24) into master (47256ca) will increase coverage by 0.07%.
The diff coverage is 87.80%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1909      +/-   ##
==========================================
+ Coverage   85.02%   85.10%   +0.07%     
==========================================
  Files         152      152              
  Lines       18883    18913      +30     
==========================================
+ Hits        16056    16096      +40     
+ Misses       2827     2817      -10     
Impacted Files Coverage Δ
panel/io/state.py 56.21% <83.33%> (+4.68%) ⬆️
panel/io/server.py 65.71% <88.57%> (+2.96%) ⬆️
panel/io/rest.py 31.63% <0.00%> (+4.08%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 47256ca...b551b24. Read the comment docs.

@philippjfr philippjfr merged commit 7dacd8a into master Jan 17, 2021
@philippjfr philippjfr deleted the session_info_create branch January 17, 2021 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant