Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FastGridTemplate: Don't use persisted layout if save_layout=False #2580

Merged
merged 1 commit into from
Jul 28, 2021

Conversation

MarcSkovMadsen
Copy link
Collaborator

Fixes #2579

In the below video the LocalStorage contains a persisted layout. As you can see it's now only used when save_layout=True.

persisted_layout.mp4

FYI. @nghenzi and @syamajala I've also added this change to the ReactTemplate. Please review if you can find the time. Thanks.

@MarcSkovMadsen MarcSkovMadsen added this to the v0.12.1 milestone Jul 27, 2021
@philippjfr philippjfr merged commit d2eea9c into master Jul 28, 2021
@philippjfr philippjfr deleted the dont-use-persisted-layout branch July 28, 2021 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FastGridTemplate with save_layout=False uses persisted layout if it exists.
2 participants