Bump bokeh to 3.1.0dev4 #4479
Merged
Bump bokeh to 3.1.0dev4 #4479
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #4479 +/- ##
==========================================
+ Coverage 74.12% 82.20% +8.08%
==========================================
Files 243 243
Lines 35321 35320 -1
==========================================
+ Hits 26181 29035 +2854
+ Misses 9140 6285 -2855
Flags with carried forward coverage won't be shown. Click here to find out more.
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
mattpap
reviewed
Feb 28, 2023
| export class DOMEvent extends ModelEvent { | ||
| event_name: string = "dom_event" | ||
| publish: boolean = true |
There was a problem hiding this comment.
Both should be prototype members, not instance members, though that also works. In bokehjs we use a decorator to make sure this is set up properly:
import {event} from "@bokehjs/core/bokeh_events"
@event("dom_event")
export class DOMEvent extends ModelEvent {
...
}Alternatively one can use this:
export class DOMEvent extends ModelEvent {
static {
this.prototype.event_name = "dom_event"
this.prototype.publish = true
}
}I will make a change, so that publish = true is actually the default, regardless how a event is defined.
There was a problem hiding this comment.
Will fix this in another PR.
There was a problem hiding this comment.
Fixed in bokeh/bokeh#12871.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.