Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid needlessly updating stylesheets #5278

Merged
merged 1 commit into from
Jul 18, 2023
Merged

Avoid needlessly updating stylesheets #5278

merged 1 commit into from
Jul 18, 2023

Conversation

philippjfr
Copy link
Member

When using a Design we frequently needlessly re-applied stylesheets even though they technically had not changed. Also when first adding a component to a layout they would incorrectly use CDN resources even if that was not requested. This PR should avoid needless flickering and re-rendering.

@codecov
Copy link

codecov bot commented Jul 18, 2023

Codecov Report

Merging #5278 (196c082) into main (8fd765b) will increase coverage by 1.14%.
The diff coverage is 95.65%.

@@            Coverage Diff             @@
##             main    #5278      +/-   ##
==========================================
+ Coverage   72.59%   73.74%   +1.14%     
==========================================
  Files         274      274              
  Lines       39649    39666      +17     
==========================================
+ Hits        28783    29251     +468     
+ Misses      10866    10415     -451     
Flag Coverage Δ
unitexamples-tests 73.74% <95.65%> (+1.14%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
panel/theme/base.py 88.49% <95.65%> (+0.81%) ⬆️

... and 23 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 1c5bebe into main Jul 18, 2023
8 of 14 checks passed
@philippjfr philippjfr deleted the stylesheet_reapply branch July 18, 2023 10:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant