Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more guards to Tabulator rendering pipelines #5412

Merged
merged 2 commits into from
Aug 17, 2023
Merged

Conversation

philippjfr
Copy link
Member

More checks to ensure everything is initialized by the time it runs to ensure we don't error while Tabulator is still updating.

@codecov
Copy link

codecov bot commented Aug 17, 2023

Codecov Report

Merging #5412 (144247a) into main (2c6e165) will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #5412      +/-   ##
==========================================
- Coverage   72.69%   72.65%   -0.05%     
==========================================
  Files         274      274              
  Lines       39862    39862              
==========================================
- Hits        28977    28961      -16     
- Misses      10885    10901      +16     
Flag Coverage Δ
unitexamples-tests 72.65% <ø> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 31035d4 into main Aug 17, 2023
@philippjfr philippjfr deleted the tabulator_guards branch August 17, 2023 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant