-
-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix DeckGL TextLayer issues #5427
Conversation
The last issue I need to fix is how to handle the fact that DeckGL JS supports data rows containing lists like the The data = {
"layers": [
{
"@@type": "TextLayer",
"data": [
{
"name": "24th St. Mission (24TH)",
"code": "24",
"address": "2800 Mission Street, San Francisco CA 94110",
"entries": 12817,
"exits": 12529,
"coordinates": [-122.418466, 37.752254]
}
],
}
],
}
pane = DeckGL(data) This can be handled in many ways
cds.to_df()
*** ValueError: Per-column arrays must each be 1-dimensional But again this could be a costly operation.
Please advice @philippjfr. Thanks. |
Codecov Report
@@ Coverage Diff @@
## main #5427 +/- ##
==========================================
- Coverage 72.59% 70.17% -2.43%
==========================================
Files 274 274
Lines 39964 40005 +41
==========================================
- Hits 29013 28073 -940
- Misses 10951 11932 +981
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 14 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This example does not yet work for me with this PR: https://deckgl.readthedocs.io/en/latest/gallery/text_layer.html |
Nevermind, I see that this is because of the coordinates issue. Will fix. |
Thanks so much for finalizing this. |
Closes #5346