Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure FloatPanel correctly exposes its children #5433

Merged
merged 1 commit into from
Aug 24, 2023
Merged

Conversation

philippjfr
Copy link
Member

Fixes #5373

@codecov
Copy link

codecov bot commented Aug 24, 2023

Codecov Report

Merging #5433 (fefc7b7) into main (970399a) will decrease coverage by 2.50%.
Report is 1 commits behind head on main.
The diff coverage is 20.00%.

@@            Coverage Diff             @@
##             main    #5433      +/-   ##
==========================================
- Coverage   83.30%   80.80%   -2.50%     
==========================================
  Files         274      274              
  Lines       40005    40010       +5     
==========================================
- Hits        33325    32331     -994     
- Misses       6680     7679     +999     
Flag Coverage Δ
ui-tests 40.71% <20.00%> (-0.01%) ⬇️
unitexamples-tests 70.09% <20.00%> (-2.53%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/layout/float.py 85.71% <20.00%> (-8.89%) ⬇️

... and 19 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit b08976c into main Aug 24, 2023
12 of 15 checks passed
@philippjfr philippjfr deleted the fix_float_panel branch August 24, 2023 15:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

js_on_click not working for Button inside FloatPanel
1 participant