-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor ReactiveHTML docs #5448
Merged
Merged
Changes from 28 commits
Commits
Show all changes
29 commits
Select commit
Hold shift + click to select a range
c2d2c50
start reactive-html docs refactor
3bbbcb1
minor fixes
90d694f
more reactive html docs
f0846cf
more ReactiveHTML docs refactor
3b145cd
work on reactive html docs
437c8e8
add reactivehtml dataframe how to
ca1a44b
add reactivehtml panes
67ad253
wip
bd53e0e
wip reactivehtml docs
f7dcf62
wip reactivehtml docs
4a7843d
reactivehtml - loop with .doc
ca5e535
add _dom_events description
6e05969
update reactive_html_components
MarcSkovMadsen 0f48349
fix after read
MarcSkovMadsen 26a0ae8
fix test issues
MarcSkovMadsen f5d9f1b
fix test issues
MarcSkovMadsen 37be2ac
test examples
MarcSkovMadsen c2c9530
add missing links
MarcSkovMadsen 905c8b7
Merge branch 'main' of https://github.com/holoviz/panel into enhancem…
MarcSkovMadsen 4396451
fix resolve issue
MarcSkovMadsen 78423a6
add anywidget comparison
MarcSkovMadsen a004366
remove failing description
MarcSkovMadsen 3e938b1
make links work. improve
MarcSkovMadsen e78c722
comment on react etc.
MarcSkovMadsen 3471493
fix cards layout
MarcSkovMadsen a99bad6
fix reactivehtml issues
MarcSkovMadsen 5f5e330
Update doc/explanation/components/reactive_html_components.md
MarcSkovMadsen 6976b72
apply feedback from thomascsantos
MarcSkovMadsen c3f4be7
[pre-commit.ci] auto fixes from pre-commit.com hooks
pre-commit-ci[bot] File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file was deleted.
Oops, something went wrong.
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel like this "big" topic of custom components and
ReactiveHTML
is very much hidden because its several clicks downAlso I believe that it would make navigation easier of the sections and cards where aligned as much as possible between
how-to
andexplanation
pages. That would make navigation easier as you don't have to remember seperately where to find ReactiveHTML components material for how-to guides and for explanation.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would recommend restructering the
how-to
navigation by having aComponents
section and moving the following cards thereThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sounds reasonable to me.