Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure columns are deleted when updating traces on Plotly pane #5464

Merged
merged 1 commit into from
Aug 31, 2023

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Aug 31, 2023

Fixes #5456
Fixes #5457

@codecov
Copy link

codecov bot commented Aug 31, 2023

Codecov Report

Merging #5464 (6222257) into main (70e13bc) will decrease coverage by 2.42%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main    #5464      +/-   ##
==========================================
- Coverage   72.52%   70.11%   -2.42%     
==========================================
  Files         274      274              
  Lines       40089    40111      +22     
==========================================
- Hits        29075    28124     -951     
- Misses      11014    11987     +973     
Flag Coverage Δ
unitexamples-tests 70.11% <100.00%> (-2.42%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/pane/plotly.py 80.00% <100.00%> (+0.33%) ⬆️
panel/tests/pane/test_plotly.py 98.74% <100.00%> (+0.16%) ⬆️

... and 18 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 4721351 into main Aug 31, 2023
11 of 15 checks passed
@philippjfr philippjfr deleted the plotly_trace_column_delete branch August 31, 2023 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

plotly kde plot with histogram corrupted plotly figure not refreshed fully
1 participant