Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure visibility is applied when initialized as False #5508

Merged
merged 2 commits into from
Sep 14, 2023
Merged

Conversation

philippjfr
Copy link
Member

Fixes #5354

@philippjfr philippjfr marked this pull request as ready for review September 14, 2023 11:29
@codecov
Copy link

codecov bot commented Sep 14, 2023

Codecov Report

Merging #5508 (fc593cb) into main (65d0a5b) will increase coverage by 11.01%.
The diff coverage is 100.00%.

@@             Coverage Diff             @@
##             main    #5508       +/-   ##
===========================================
+ Coverage   72.56%   83.57%   +11.01%     
===========================================
  Files         276      276               
  Lines       40152    40162       +10     
===========================================
+ Hits        29136    33567     +4431     
+ Misses      11016     6595     -4421     
Flag Coverage Δ
ui-tests 41.40% <100.00%> (?)
unitexamples-tests 72.46% <10.00%> (-0.11%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/tests/ui/pane/test_markup.py 100.00% <100.00%> (+72.00%) ⬆️

... and 72 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 1b88afa into main Sep 14, 2023
13 of 15 checks passed
@philippjfr philippjfr deleted the fix_visibility branch September 14, 2023 12:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant