Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace inbuilt support for references with Param based references #5530

Merged
merged 6 commits into from
Sep 24, 2023

Conversation

philippjfr
Copy link
Member

Builds on holoviz/param#843 to replace existing support for Param references with internal support in Param. This has the major benefit that references can now be updated and that we allow for nested references.

@codecov
Copy link

codecov bot commented Sep 24, 2023

Codecov Report

Merging #5530 (e4b5b81) into main (7088c68) will decrease coverage by 0.07%.
Report is 1 commits behind head on main.
The diff coverage is 98.03%.

@@            Coverage Diff             @@
##             main    #5530      +/-   ##
==========================================
- Coverage   83.59%   83.52%   -0.07%     
==========================================
  Files         277      277              
  Lines       40387    40269     -118     
==========================================
- Hits        33760    33636     -124     
- Misses       6627     6633       +6     
Flag Coverage Δ
ui-tests 41.38% <81.37%> (-0.01%) ⬇️
unitexamples-tests 72.38% <98.03%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
panel/pane/vega.py 82.10% <ø> (ø)
panel/depends.py 72.72% <50.00%> (+2.72%) ⬆️
panel/__init__.py 100.00% <100.00%> (ø)
panel/pane/base.py 84.53% <100.00%> (-1.30%) ⬇️
panel/pane/holoviews.py 79.28% <100.00%> (+0.03%) ⬆️
panel/pane/ipywidget.py 49.38% <100.00%> (-2.52%) ⬇️
panel/pane/markup.py 90.04% <100.00%> (ø)
panel/pane/perspective.py 68.30% <100.00%> (ø)
panel/pane/plot.py 68.83% <100.00%> (+0.27%) ⬆️
panel/pane/plotly.py 80.00% <100.00%> (ø)
... and 14 more

... and 10 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit c5ad221 into main Sep 24, 2023
@philippjfr philippjfr deleted the refs branch September 24, 2023 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant