Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guard undefined values from being set on BrowserInfo #5588

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

philippjfr
Copy link
Member

Fixes #5570

@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

Merging #5588 (8702fa0) into main (a1d4b08) will decrease coverage by 39.90%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##             main    #5588       +/-   ##
===========================================
- Coverage   80.97%   41.07%   -39.90%     
===========================================
  Files         275      275               
  Lines       39471    39471               
===========================================
- Hits        31960    16213    -15747     
- Misses       7511    23258    +15747     
Flag Coverage Δ
ui-tests 40.71% <ø> (+<0.01%) ⬆️
unitexamples-tests 24.08% <ø> (-46.95%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 164 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 9a66efe into main Oct 5, 2023
12 of 15 checks passed
@philippjfr philippjfr deleted the browser_info_guard branch October 5, 2023 07:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error: panel.models.browser.BrowserInfo(_).timezone given invalid value: undefined
1 participant