Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Tabulator.style applies correctly with changing data #5757

Merged
merged 2 commits into from
Oct 30, 2023

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Oct 27, 2023

The Tabulator.style.background_gradient and Tabulator.style.bar methods keep track of the columns that it can apply these styling options too, which means that if the data changes the styles will no longer correctly apply. Therefore we introduce a utility that will update the boolean index of column inside the Styler._todo list.

  • Add tests

@codecov
Copy link

codecov bot commented Oct 27, 2023

Codecov Report

Merging #5757 (3157237) into main (6640c83) will increase coverage by 0.03%.
Report is 1 commits behind head on main.
The diff coverage is 75.00%.

@@            Coverage Diff             @@
##             main    #5757      +/-   ##
==========================================
+ Coverage   73.66%   73.69%   +0.03%     
==========================================
  Files         289      289              
  Lines       42113    42135      +22     
==========================================
+ Hits        31021    31050      +29     
+ Misses      11092    11085       -7     
Flag Coverage Δ
unitexamples-tests 73.69% <75.00%> (+0.03%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Coverage Δ
panel/widgets/tables.py 87.55% <60.00%> (-0.15%) ⬇️
panel/util/__init__.py 83.00% <78.94%> (-0.27%) ⬇️

... and 4 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@philippjfr philippjfr merged commit 63d8bb6 into main Oct 30, 2023
1 of 2 checks passed
@philippjfr philippjfr deleted the styler_update branch October 30, 2023 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant