Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pane.clone did the same look up three times which was costly.
This changes to one lookup and also makes the code more readable.
Measurement 1
Running pytest on below code shows ~3% speed up consistently.
The reason why I found this is that I can see in apps
.clone
loops overself.param.values().items()
. And loops overself.param.values().items()
takes up +5% of the time of loading apps in my tests. My hypothesis is that that one could be improved significantly.