Fix obj.save()
when threading is enabled
#5993
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5957
.save()
internally callswith config.set(embed=True)
, andconfig.set()
stores the original values of all the config Parameters plus their overrides, to reset them later when the context manager exits. This leads toconfig.__setattr__
being called quite a lot and I noticed that whilenthreads
was declared inconfig._globals
, setting_nthreads
would still go through the code path that sets upconfig._session_config
. This change deals with such case, i.e. when the string declared inconfig._globals
is not a reference to the parameter name itself (e.g.admin_plugins
) but to its property (e.g.nthreads
,comms
).