-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DateRangePicker widget #6027
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6027 +/- ##
===========================================
- Coverage 84.68% 72.89% -11.79%
===========================================
Files 291 291
Lines 43730 43793 +63
===========================================
- Hits 37032 31924 -5108
- Misses 6698 11869 +5171
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
0e21e68
to
109c2ac
Compare
109c2ac
to
90f15cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@philippjfr may I ask, when this Daterangepicker is available in an official release? And does it also support single date picking (start_date = end_date)? This is currently not supported by |
Tagging 1.4.0rc1 on Monday so hopefully over the course of next week. |
On the second part I'd have to check, you could try it out with 1.4.0b2 today. |
On monday i will try with 1.4.0b2, thank you! |
Same day selection is supported. |
Replaces #2804
Closes #5844 and maybe #3789
As far as I know this reuse of Bokeh's implementation works fine.
As it's my first widget addition I'm open to suggestions to get closer to existing practices.
A small code to try it: