Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forward not ChatFeed params to message_params #6089

Merged
merged 2 commits into from
Jan 10, 2024
Merged

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Dec 19, 2023

Makes it possible to do:

import panel as pn

pn.chat.ChatInterface(
    reaction_icons={"like": "thumb-up", "dislike": "thumb-down", "favorite": "heart"}, reactions=["like"]
).servable()

Rather than awkwardly nesting dicts:

import panel as pn

pn.chat.ChatInterface(
    message_params={"reaction_icons": {"like": "thumb-up", "dislike": "thumb-down", "favorite": "heart"}, "reactions": ["like"]}
).servable()

@ahuang11 ahuang11 requested a review from philippjfr December 19, 2023 20:39
@ahuang11 ahuang11 changed the title Forward message params to ChatMessage Forward not ChatFeed params to message_params Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (5b89692) 84.66% compared to head (214d04c) 84.67%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6089   +/-   ##
=======================================
  Coverage   84.66%   84.67%           
=======================================
  Files         296      296           
  Lines       44057    44070   +13     
=======================================
+ Hits        37302    37315   +13     
  Misses       6755     6755           
Flag Coverage Δ
ui-tests 40.62% <7.69%> (-0.01%) ⬇️
unitexamples-tests 72.75% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 445ff15 into main Jan 10, 2024
13 checks passed
@philippjfr philippjfr deleted the forward_message_params branch January 10, 2024 15:12
philippjfr pushed a commit that referenced this pull request Jan 17, 2024
* Forward message params to ChatMessage

* Update docs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants