Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add filter_by kwarg to serialize for ChatFeed #6090

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Dec 19, 2023

Closes #6048

If I'm fine-tuning and I only want some responses, I want to make it easier to only select the messages with the desired reactions

@ahuang11 ahuang11 changed the title Add filter by Add filter_by kwarg to serialize for ChatFeed Dec 19, 2023
Copy link

codecov bot commented Dec 19, 2023

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (5b89692) 84.66% compared to head (d6574c9) 84.66%.

Files Patch % Lines
panel/chat/interface.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6090      +/-   ##
==========================================
- Coverage   84.66%   84.66%   -0.01%     
==========================================
  Files         296      296              
  Lines       44057    44068      +11     
==========================================
+ Hits        37302    37310       +8     
- Misses       6755     6758       +3     
Flag Coverage Δ
ui-tests 40.62% <11.76%> (-0.01%) ⬇️
unitexamples-tests 72.73% <94.11%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 requested a review from philippjfr January 10, 2024 17:43
@philippjfr philippjfr merged commit 1804d15 into main Jan 12, 2024
12 of 13 checks passed
@philippjfr philippjfr deleted the add_filter_by branch January 12, 2024 16:05
philippjfr pushed a commit that referenced this pull request Jan 17, 2024
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add filter_by_reactions to serialize method in ChatFeed
2 participants