Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update bootstrap.html - Changing navbar toggle icon to white #6111

Merged
merged 5 commits into from
Feb 17, 2024

Conversation

mayonnaisecolouredbenz7
Copy link
Contributor

Changing the navbar toggle icon to white as is the case in other templates.

I attempted to create the variable in the css file that the template is referring to originally bs-navbar-toggler-icon-bg. However it wasn't overriding the variable shown in the console:
image

So it was easier to explicitly change the background-image property in the navbar-toggler-icon class in html file

Changing the navbar toggle icon to white as is the case in other templates
@philippjfr
Copy link
Member

pre-commit.ci autofix

Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (445ff15) 84.70% compared to head (d7ce65b) 83.88%.
Report is 15 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6111      +/-   ##
==========================================
- Coverage   84.70%   83.88%   -0.83%     
==========================================
  Files         296      299       +3     
  Lines       44320    44677     +357     
==========================================
- Hits        37542    37476      -66     
- Misses       6778     7201     +423     
Flag Coverage Δ
ui-tests 40.13% <ø> (-0.60%) ⬇️
unitexamples-tests 72.21% <ø> (-0.40%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

I attempted to create the variable in the css file that the template is referring to originally bs-navbar-toggler-icon-bg.

I suspect the problem is that you have to run a command to bundle the CSS files when you want them to be reflected using panel bundle --templates --only-local (which is not documented). Overall I'd prefer using the variable.

@mayonnaisecolouredbenz7
Copy link
Contributor Author

Made the necessary changes

@philippjfr philippjfr merged commit f9d9a58 into holoviz:main Feb 17, 2024
13 of 15 checks passed
@philippjfr
Copy link
Member

Thank you @mayonnaisecolouredbenz7!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants