Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add activity indicator to ChatMessage #6153

Merged
merged 5 commits into from
Jan 9, 2024
Merged

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Jan 4, 2024

Pretty happy with this implementation; shows dot while streaming:

Screen.Recording.2024-01-04.at.11.00.14.AM.mov

(The extraneous padding/shifting of the message is fixed in the later commits)

@ahuang11 ahuang11 changed the title Add streaming dot again Add streaming dot to ChatMessage Jan 4, 2024
Copy link

codecov bot commented Jan 4, 2024

Codecov Report

Attention: 1 lines in your changes are missing coverage. Please review.

Comparison is base (46e0639) 84.69% compared to head (4ef6cfe) 84.60%.
Report is 6 commits behind head on main.

❗ Current head 4ef6cfe differs from pull request most recent head c08144c. Consider uploading reports for the commit c08144c to get more accurate results

Files Patch % Lines
panel/chat/feed.py 94.11% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6153      +/-   ##
==========================================
- Coverage   84.69%   84.60%   -0.09%     
==========================================
  Files         296      296              
  Lines       44184    44196      +12     
==========================================
- Hits        37423    37394      -29     
- Misses       6761     6802      +41     
Flag Coverage Δ
ui-tests 40.72% <8.69%> (-0.02%) ⬇️
unitexamples-tests 72.53% <95.65%> (-0.09%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ahuang11 ahuang11 marked this pull request as ready for review January 9, 2024 00:18
@ahuang11 ahuang11 changed the title Add streaming dot to ChatMessage Add activity indicator to ChatMessage Jan 9, 2024
@philippjfr philippjfr merged commit a793b36 into main Jan 9, 2024
14 checks passed
@philippjfr philippjfr deleted the add_streaming_dot_again branch January 9, 2024 18:07
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants