Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes and guards for rendering ChatFeed and Card #6177

Merged
merged 3 commits into from
Jan 10, 2024
Merged

Conversation

philippjfr
Copy link
Member

@philippjfr philippjfr commented Jan 9, 2024

  • Ensure Theme does not error out if a child of a layout has not yet initialized a model
  • Do not re-render Card superfluously, which could cause race conditions and rendering issues
  • Ensure that ChatFeed reflects the model of layout it is rendering to ensure that components that assume a component has a corresponding model will find one.

Fixes #6140

Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: 5 lines in your changes are missing coverage. Please review.

Comparison is base (d40dd3b) 84.67% compared to head (9632f4d) 84.59%.

Files Patch % Lines
panel/chat/feed.py 0.00% 4 Missing ⚠️
panel/theme/base.py 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6177      +/-   ##
==========================================
- Coverage   84.67%   84.59%   -0.08%     
==========================================
  Files         296      296              
  Lines       44224    44229       +5     
==========================================
- Hits        37445    37415      -30     
- Misses       6779     6814      +35     
Flag Coverage Δ
ui-tests 40.71% <0.00%> (-0.02%) ⬇️
unitexamples-tests 72.51% <16.66%> (-0.07%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit f4c947d into main Jan 10, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the theme_apply_guard branch January 10, 2024 00:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Key error in viewable._models[mref] if pn.Card is used with ChatFeed and Bootstrap
1 participant