Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

correct duplicate wording #6188

Merged

Conversation

fayssal-el-elmofatiche
Copy link
Contributor

@fayssal-el-elmofatiche fayssal-el-elmofatiche commented Jan 12, 2024

the word "construct" was duplicated. NeoVim decided to do a bit of MarkDown reformatting upon saving as well.

@philippjfr
Copy link
Member

Thanks. That said I don't quite understand the reformatting, _ is not preferable over *, they're equivalent. It's also inconsistent with the rest of the codebase, so on balance I'd prefer not to apply those changes.

@fayssal-el-elmofatiche
Copy link
Contributor Author

I thought I should revert it as well, but it is indeed equivalent. Let me take it out to stay consistent with the rest as you mentioned.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really appreciate it, thanks!

@philippjfr philippjfr merged commit dfd0155 into holoviz:main Jan 12, 2024
1 check passed
philippjfr pushed a commit that referenced this pull request Jan 17, 2024
This was referenced Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants