Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle duplicate attempts to refresh auth tokens #6233

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

philippjfr
Copy link
Member

When an auth token refresh is in process we should not attempt another refresh at the same time, so we detect the case where the refresh is in flight and simply await it by sleeping until the refreshed tokens are available.

@philippjfr philippjfr added this to the v1.3.7 milestone Jan 18, 2024
Copy link

codecov bot commented Jan 18, 2024

Codecov Report

Attention: 15 lines in your changes are missing coverage. Please review.

Comparison is base (3a3b1be) 84.17% compared to head (bde5e56) 22.30%.
Report is 3 commits behind head on main.

Files Patch % Lines
panel/io/notebook.py 30.76% 9 Missing ⚠️
panel/auth.py 0.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6233       +/-   ##
===========================================
- Coverage   84.17%   22.30%   -61.88%     
===========================================
  Files         301      301               
  Lines       45099    45114       +15     
===========================================
- Hits        37963    10061    -27902     
- Misses       7136    35053    +27917     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 22.30% <21.05%> (-49.55%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 156cd24 into main Jan 18, 2024
11 of 15 checks passed
@philippjfr philippjfr deleted the duplicate_refresh_token branch January 18, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant