-
-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add downloads badge to table #6283
Conversation
@@ -18,6 +18,10 @@ Enjoying Panel? Show your support with a [Github star](https://github.com/holovi | |||
<table> | |||
<tbody> | |||
<tr> | |||
<td>Downloads</td> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we add the conda downloads of 170k too?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep why not. The conda badge on pyviz.org is actually manually built when the site is built (see this script https://github.com/pyviz/pyviz.org/blob/master/tools/conda_downloads.py). It's available at this URL for Panel: https://pyviz.org/_static/cache/panel_conda_downloads_badge.svg.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't suppose it's possible to combine the pip and conda downloads into a single badge with a single number? I don't think most people would care about the distinction.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1, certainly as a first cut.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick look at the screenshot. It seems to lack a space between the badges, and maybe change downloads to PyPi downloads or something like that.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The badge label is default to Downloads; not sure how to change it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
I think we should advertise it since it's pretty impressive!