Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add downloads badge to table #6283

Merged
merged 5 commits into from
Jan 30, 2024
Merged

Add downloads badge to table #6283

merged 5 commits into from
Jan 30, 2024

Conversation

ahuang11
Copy link
Contributor

I think we should advertise it since it's pretty impressive!

image

@@ -18,6 +18,10 @@ Enjoying Panel? Show your support with a [Github star](https://github.com/holovi
<table>
<tbody>
<tr>
<td>Downloads</td>
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add the conda downloads of 170k too?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep why not. The conda badge on pyviz.org is actually manually built when the site is built (see this script https://github.com/pyviz/pyviz.org/blob/master/tools/conda_downloads.py). It's available at this URL for Panel: https://pyviz.org/_static/cache/panel_conda_downloads_badge.svg.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't suppose it's possible to combine the pip and conda downloads into a single badge with a single number? I don't think most people would care about the distinction.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm leaning towards keeping them separate, mainly because I don't know how and I don't want this small change to take up too much time

Also, I think people can do some quick mental math to combine those numbers
image

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1, certainly as a first cut.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick look at the screenshot. It seems to lack a space between the badges, and maybe change downloads to PyPi downloads or something like that.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The badge label is default to Downloads; not sure how to change it.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

README.md Outdated Show resolved Hide resolved
Co-authored-by: Simon Høxbro Hansen <simon.hansen@me.com>
@philippjfr philippjfr merged commit a18106b into main Jan 30, 2024
6 checks passed
@philippjfr philippjfr deleted the add-download-badge branch January 30, 2024 22:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants