-
-
Notifications
You must be signed in to change notification settings - Fork 525
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't pop ChatInterface variables #6290
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #6290 +/- ##
===========================================
+ Coverage 40.72% 84.19% +43.47%
===========================================
Files 301 301
Lines 45219 45247 +28
===========================================
+ Hits 18414 38095 +19681
+ Misses 26805 7152 -19653
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ahuang11 please review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
Co-authored-by: Andrew <15331990+ahuang11@users.noreply.github.com>
Looking at the failing test and a bit at the code. I think there are some possibilities:
I think I like 2 the most. |
I like 2 too. |
7b31ba5
to
ad3c846
Compare
Without these changes, ChatInterface will not use the new username.