Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Jupyter Preview error handling and error template #6496

Merged
merged 2 commits into from
Mar 14, 2024

Conversation

philippjfr
Copy link
Member

We now intercept exceptions that occur in the application when running the Jupyter Preview and display the traceback to the user. Additionally I replaced the old, rather gaudy error template with a new cleaner error page:

Screenshot 2024-03-14 at 20 36 16

Fixes #6256

Copy link

codecov bot commented Mar 14, 2024

Codecov Report

Attention: Patch coverage is 0% with 12 lines in your changes are missing coverage. Please review.

Project coverage is 71.37%. Comparing base (78d95d4) to head (0bb227d).

Files Patch % Lines
panel/io/jupyter_executor.py 0.00% 9 Missing ⚠️
panel/tests/ui/io/test_jupyter_server_extension.py 0.00% 2 Missing ⚠️
panel/io/handlers.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6496       +/-   ##
===========================================
- Coverage   82.03%   71.37%   -10.66%     
===========================================
  Files         314      314               
  Lines       46351    46358        +7     
===========================================
- Hits        38024    33089     -4935     
- Misses       8327    13269     +4942     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 71.37% <0.00%> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr mentioned this pull request Mar 14, 2024
@philippjfr philippjfr merged commit aea6cdf into main Mar 14, 2024
12 of 15 checks passed
@philippjfr philippjfr deleted the jupyter_error_handling branch March 14, 2024 21:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance Jupyter Preview Error Message if notebook raise exception
1 participant