Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix floating point error in IntRangeSlider #6516

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

hoxbro
Copy link
Member

@hoxbro hoxbro commented Mar 18, 2024

Fixes #6483

@hoxbro hoxbro force-pushed the floatingpoint_error branch from b6999b7 to 2e88d32 Compare March 18, 2024 09:03
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 82.92%. Comparing base (ddedd8d) to head (e4e87b4).

Files Patch % Lines
panel/widgets/slider.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6516      +/-   ##
==========================================
- Coverage   82.93%   82.92%   -0.02%     
==========================================
  Files         313      313              
  Lines       45864    45872       +8     
==========================================
+ Hits        38039    38040       +1     
- Misses       7825     7832       +7     
Flag Coverage Δ
ui-tests 40.09% <70.00%> (-0.01%) ⬇️
unitexamples-tests 71.13% <20.00%> (-0.02%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 003e0f8 into main Mar 18, 2024
15 of 16 checks passed
@philippjfr philippjfr deleted the floatingpoint_error branch March 18, 2024 10:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent IntRangeSlider Value Behavior in Panel Library
2 participants