Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mention code highlighting in Markdown and ChatFeed #6519

Merged
merged 2 commits into from
Mar 18, 2024
Merged

Conversation

ahuang11
Copy link
Contributor

I'm not sure if admonitions can be used in Reference notebooks?

@ahuang11 ahuang11 changed the title Mention code highlighting in Markdown and Feed Mention code highlighting in Markdown and ChatFeed Mar 18, 2024
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.91%. Comparing base (864a514) to head (6e5a9fc).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #6519   +/-   ##
=======================================
  Coverage   82.91%   82.91%           
=======================================
  Files         313      313           
  Lines       45902    45902           
=======================================
+ Hits        38060    38061    +1     
+ Misses       7842     7841    -1     
Flag Coverage Δ
ui-tests 40.09% <ø> (-0.01%) ⬇️
unitexamples-tests 71.13% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Yes, let's use them, but let's go for the ::: syntax to make it clear that this is special syntax.

@ahuang11
Copy link
Contributor Author

ahuang11 commented Mar 18, 2024

Is :::{note} what you meant? Or is there :::{admonition}

@philippjfr
Copy link
Member

Let's go with :::{note}

@ahuang11
Copy link
Contributor Author

Okay, I think it's ready then.

@philippjfr philippjfr merged commit 3f9324f into main Mar 18, 2024
15 checks passed
@philippjfr philippjfr deleted the mention_pygments branch March 18, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants