Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix stream None base message #6522

Merged
merged 1 commit into from
Mar 19, 2024
Merged

Fix stream None base message #6522

merged 1 commit into from
Mar 19, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Mar 18, 2024

This didn't stream anything before (and was actually stuck in an infinite while loop)

import panel as pn
chat_feed = pn.chat.ChatFeed()
message = pn.chat.ChatMessage(user="System")
chat_feed.send(message)
for i in range(0, 12):
    chat_feed.stream(f"new message {i}", message=message)

Originally discovered here:
https://discourse.holoviz.org/t/stream-text-to-chatinterface/6976/15?u=ahuang11

@ahuang11 ahuang11 added this to the v1.4.0 milestone Mar 18, 2024
@ahuang11 ahuang11 requested a review from philippjfr March 18, 2024 19:53
Copy link

codecov bot commented Mar 18, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 82.91%. Comparing base (864a514) to head (a46858b).
Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6522      +/-   ##
==========================================
- Coverage   82.91%   82.91%   -0.01%     
==========================================
  Files         313      313              
  Lines       45902    45917      +15     
==========================================
+ Hits        38060    38070      +10     
- Misses       7842     7847       +5     
Flag Coverage Δ
ui-tests 40.10% <18.18%> (-0.01%) ⬇️
unitexamples-tests 71.13% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 80d7257 into main Mar 19, 2024
15 checks passed
@philippjfr philippjfr deleted the fix_stream_none branch March 19, 2024 12:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants