Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor handling of component stylesheets #6571

Merged
merged 5 commits into from
Mar 25, 2024

Conversation

philippjfr
Copy link
Member

Follow up to #6563 which avoids adding full stylesheets as link tags.

Copy link

codecov bot commented Mar 25, 2024

Codecov Report

Attention: Patch coverage is 17.85714% with 23 lines in your changes are missing coverage. Please review.

Project coverage is 22.20%. Comparing base (a396599) to head (67ea85c).
Report is 2 commits behind head on main.

Files Patch % Lines
panel/io/resources.py 7.69% 12 Missing ⚠️
panel/template/base.py 10.00% 9 Missing ⚠️
panel/template/golden/__init__.py 50.00% 1 Missing ⚠️
panel/theme/base.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6571       +/-   ##
===========================================
- Coverage   82.98%   22.20%   -60.78%     
===========================================
  Files         313      313               
  Lines       46023    46032        +9     
===========================================
- Hits        38191    10222    -27969     
- Misses       7832    35810    +27978     
Flag Coverage Δ
ui-tests ?
unitexamples-tests 22.20% <17.85%> (-49.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit d6f5117 into main Mar 25, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the template_stylesheet_resolve branch March 25, 2024 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant