Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure all docs pages are indexed #6615

Merged
merged 5 commits into from
Apr 1, 2024
Merged

Ensure all docs pages are indexed #6615

merged 5 commits into from
Apr 1, 2024

Conversation

MarcSkovMadsen
Copy link
Collaborator

@atisor73 contributed docs on aws but its not been released with Panel 1.4.0 because its not included in an index.

This PR fixes this.

Copy link

codecov bot commented Mar 29, 2024

Codecov Report

Attention: Patch coverage is 12.90323% with 27 lines in your changes are missing coverage. Please review.

Project coverage is 82.89%. Comparing base (d59b23b) to head (96a532b).
Report is 3 commits behind head on main.

Files Patch % Lines
panel/tests/test_docs.py 12.90% 27 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #6615      +/-   ##
==========================================
- Coverage   82.94%   82.89%   -0.06%     
==========================================
  Files         313      313              
  Lines       46090    46121      +31     
==========================================
+ Hits        38231    38232       +1     
- Misses       7859     7889      +30     
Flag Coverage Δ
ui-tests 40.00% <12.90%> (-0.03%) ⬇️
unitexamples-tests 71.19% <12.90%> (-0.05%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll add a unit test to this PR ensuring that all files are added to an index.

@philippjfr philippjfr changed the title Fix aws deployment Ensure all docs pages are indexed Apr 1, 2024
@philippjfr philippjfr merged commit 722a928 into main Apr 1, 2024
13 of 15 checks passed
@philippjfr philippjfr deleted the fix/aws-deployment branch April 1, 2024 12:22
@philippjfr philippjfr added this to the v1.4.1 milestone Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants