Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for automatically determining optimal Tabulator page_size #6978

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

philippjfr
Copy link
Member

Initial attempt at letting Tabulator automatically determine the correct page_size for a particular height.

panel/models/tabulator.ts Outdated Show resolved Hide resolved
Copy link

codecov bot commented Aug 1, 2024

Codecov Report

Attention: Patch coverage is 79.41176% with 7 lines in your changes missing coverage. Please review.

Project coverage is 82.23%. Comparing base (c15e5db) to head (aa4c497).
Report is 41 commits behind head on main.

Files Patch % Lines
panel/tests/ui/widgets/test_tabulator.py 46.15% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main    #6978       +/-   ##
===========================================
+ Coverage   40.37%   82.23%   +41.86%     
===========================================
  Files         314      326       +12     
  Lines       45937    48350     +2413     
===========================================
+ Hits        18545    39760    +21215     
+ Misses      27392     8590    -18802     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 7c90f7b into main Aug 1, 2024
15 checks passed
@philippjfr philippjfr deleted the tabulator_page_size_auto branch August 1, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant