Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minify Player/DiscretePlayer with scale_buttons/visible_buttons/visible_loop_options #7065

Merged
merged 9 commits into from
Aug 14, 2024

Conversation

ahuang11
Copy link
Contributor

@ahuang11 ahuang11 commented Aug 3, 2024

Make it a little less bulky

import panel as pn

pn.extension()
pn.widgets.Player(name='test', button_scale=0.8, width=300).servable()
image

button_scale=1
image

discrete_player = pn.widgets.DiscretePlayer(name='Player', visible_buttons=["play", "pause"], scale_buttons=0.9, show_loop_controls=False, width=150)
discrete_player
image

@ahuang11 ahuang11 marked this pull request as draft August 3, 2024 04:37
@ahuang11 ahuang11 changed the title scale player button Minify Player/DiscretePlayer with scale_buttons/visible_buttons/visible_loop_options Aug 5, 2024
@ahuang11 ahuang11 marked this pull request as ready for review August 5, 2024 20:33
Copy link

codecov bot commented Aug 5, 2024

Codecov Report

Attention: Patch coverage is 62.50000% with 18 lines in your changes missing coverage. Please review.

Project coverage is 82.20%. Comparing base (a3959ec) to head (3d03fd4).
Report is 1 commits behind head on main.

Files Patch % Lines
panel/tests/ui/widgets/test_player.py 40.00% 18 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7065      +/-   ##
==========================================
- Coverage   82.22%   82.20%   -0.03%     
==========================================
  Files         327      327              
  Lines       48923    48970      +47     
==========================================
+ Hits        40229    40256      +27     
- Misses       8694     8714      +20     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr
Copy link
Member

Needs a merge/rebase it looks like.

@ahuang11
Copy link
Contributor Author

ahuang11 commented Aug 9, 2024

Ok rebased it!

Copy link
Member

@philippjfr philippjfr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Two small comments on the tests, otherwise looks good!

@ahuang11 ahuang11 merged commit 0b76e99 into main Aug 14, 2024
15 of 16 checks passed
@ahuang11 ahuang11 deleted the scale_player_button branch August 14, 2024 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants