Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ensure Tabulator selection is updated when indexes change #7066

Merged
merged 1 commit into from
Aug 3, 2024

Conversation

philippjfr
Copy link
Member

A followup to #7058 to ensure that selections reset if rows are changed.

Copy link

codecov bot commented Aug 3, 2024

Codecov Report

Attention: Patch coverage is 92.30769% with 2 lines in your changes missing coverage. Please review.

Project coverage is 82.22%. Comparing base (a93b609) to head (982a113).

Files Patch % Lines
panel/tests/ui/widgets/test_tabulator.py 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #7066      +/-   ##
==========================================
+ Coverage   82.21%   82.22%   +0.01%     
==========================================
  Files         326      326              
  Lines       48485    48504      +19     
==========================================
+ Hits        39861    39883      +22     
+ Misses       8624     8621       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@philippjfr philippjfr merged commit 7adcf3d into main Aug 3, 2024
15 checks passed
@philippjfr philippjfr deleted the selection_updates branch August 3, 2024 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant